Skip to content

Fix huggingface_hub tests in POTel #3733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix huggingface_hub tests in POTel #3733

wants to merge 2 commits into from

Conversation

@antonpirker
Copy link
Contributor

@antonpirker antonpirker commented Nov 5, 2024

No description provided.

@codecov
Copy link

codecov bot commented Nov 5, 2024 •
edited
Loading

❌ 308 Tests Failed:

Tests completed Failed Passed Skipped
19160 308 18852 4435
View the top 1 failed tests by shortest run time 
tests.test_scope test_get_current_scope_tags
Stack Traces | 0.001s run time 
tests/test_scope.py:341: in test_get_current_scope_tags
    assert scope1.client.__class__ == NonRecordingClient
E   AttributeError: client
View the full list of 2 ❄️ flaky tests 
tests.test_scope test_get_current_scope_tags

Flake rate in main: 32.20% (Passed 40 times, Failed 19 times)

Stack Traces | 0.001s run time 
tests/test_scope.py:341: in test_get_current_scope_tags
    assert scope1.client.__class__ == NonRecordingClient
E   AttributeError: 'PotelScope' object has no attribute 'client'
tests.test_scope test_get_current_scope_tags

Flake rate in main: 26.67% (Passed 55 times, Failed 20 times)

Stack Traces | 0.001s run time 
tests/test_scope.py:341: in test_get_current_scope_tags
    assert scope1.client.__class__ == NonRecordingClient
E   AttributeError: 'PotelScope' object has no attribute 'client'

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

sentrivana
sentrivana reviewed Nov 5, 2024
View reviewed changes
tests/integrations/huggingface_hub/test_huggingface_hub.py
client.text_generation(prompt="hello")

(event,) = events
(event, _) = events
Copy link
Contributor

@sentrivana sentrivana Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the extra event we're getting now? 🤔

@antonpirker antonpirker marked this pull request as draft December 4, 2024 14:42
@antonpirker antonpirker changed the title Fixed Huggingface Hub tests Fix huggingface_hub tests in POTel Dec 5, 2024
@antonpirker
Copy link
Contributor Author

antonpirker commented Dec 5, 2024

This has fixed itself, by other updates that prevented the second event from ever being captured.

@antonpirker antonpirker closed this Dec 5, 2024
@antonpirker antonpirker deleted the antonpirker/potel/huggingface branch April 22, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrivana sentrivana sentrivana left review comments

Assignees

No one assigned

Labels

Project: POTel

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antonpirker @sentrivana